Re: [PATCH 1/3] Standardize x86_64's desc_defs.h in preparation for exposure to i386.

On Wed, 2007-07-18 at 11:03 +0200, Andi Kleen wrote:
> On Wed, Jul 18, 2007 at 05:22:34PM +1000, Rusty Russell wrote:
> > However, the currently (i386-derived) x86-64 ones are suboptimal.  The
> 
> In what way are they suboptimal? 

This was badly worded.  They're "suboptimal" for use by i386 (ie. they
clash with the i386 declaration and they'd need lots of casts to convert
the code).

Of course, treating them as 2 32-bit values on x86-64 *is* suboptimal,
and this patch helps that, but that wasn't what I was talking about.

> They seem to work just fine.

Yep.   But my first attempt was to simply #include
<asm-x86_64/desc_defs.h> from asm-i386, and that doesn't work fine 8(

Thanks,
Rusty.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 1/3] Standardize x86_64's desc_defs.h in preparation for exposure to i386.
    • From: Rusty Russell <[email protected]>
  • Re: [PATCH 1/3] Standardize x86_64's desc_defs.h in preparation for exposure to i386.
    • From: Andi Kleen <[email protected]>

• Prev by Date: Re: [PATCH] block: factor out bio_check_eod()
• Next by Date: Re: [PATCH] block: factor out bio_check_eod()
• Previous by thread: Re: [PATCH 1/3] Standardize x86_64's desc_defs.h in preparation for exposure to i386.
• Next by thread: [PATCH -mm 0/5] Freezer update
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]