[PATCH] Fix leak on /proc/lockdep_stats

On Tue, Jul 17, 2007 at 02:36:10PM +0200, Ingo Molnar wrote:
> * Alexey Dobriyan <[email protected]> wrote:
> 
> > On every open/close one struct seq_operations leaks.
> > Kudos to /proc/slab_allocators.
> > 
> > Signed-off-by: Alexey Dobriyan <[email protected]>
> 
> ouch ...
> 
> Acked-by: Ingo Molnar <[email protected]>
> 
> -stable material too, as far as timer_info/stats goes.
>
> > -       .release        = seq_release,
> > +       .release        = single_release,
>
> i think seq_release() definitely needs to grow a WARN_ON() if it's being
> used on an inode that was opened via single_open(). This bug is so
> easily committed, and nothing but a small leak reminds us on it.

Yeah, I'll try to come up with something clean.

Meanwhile full single_open() audit revealed one more such leak.
The rest seems OK.

[PATCH] Fix leak on /proc/lockdep_stats

Signed-off-by: Alexey Dobriyan <[email protected]>
---

 kernel/lockdep_proc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/kernel/lockdep_proc.c
+++ b/kernel/lockdep_proc.c
@@ -339,7 +339,7 @@ static const struct file_operations proc_lockdep_stats_operations = {
 	.open		= lockdep_stats_open,
 	.read		= seq_read,
 	.llseek		= seq_lseek,
-	.release	= seq_release,
+	.release	= single_release,
 };
 
 static int __init lockdep_proc_init(void)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] Fix leaks on /proc/{*/sched,sched_debug,timer_list,timer_stats}
    • From: Alexey Dobriyan <[email protected]>
  • Re: [PATCH] Fix leaks on /proc/{*/sched,sched_debug,timer_list,timer_stats}
    • From: Ingo Molnar <[email protected]>

• Prev by Date: Re: [patch-mm 14/33] x86_64: Consolidate tsc calibration
• Next by Date: [PATCH (resend) 0/2] workqueue lockup debugging
• Previous by thread: Re: [PATCH] Fix leaks on /proc/{*/sched,sched_debug,timer_list,timer_stats}
• Next by thread: Re: [PATCH] Fix leaks on /proc/{*/sched,sched_debug,timer_list,timer_stats}
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]