Re: [PATCH] Fix leaks on /proc/{*/sched,sched_debug,timer_list,timer_stats}

* Alexey Dobriyan <[email protected]> wrote:

> On every open/close one struct seq_operations leaks.
> Kudos to /proc/slab_allocators.
> 
> Signed-off-by: Alexey Dobriyan <[email protected]>

ouch ...

Acked-by: Ingo Molnar <[email protected]>

-stable material too, as far as timer_info/stats goes.

> -       .release        = seq_release,
> +       .release        = single_release,

i think seq_release() definitely needs to grow a WARN_ON() if it's being 
used on an inode that was opened via single_open(). This bug is so 
easily committed, and nothing but a small leak reminds us on it.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] Fix leaks on /proc/{*/sched,sched_debug,timer_list,timer_stats}
    • From: Andrew Morton <[email protected]>
  • [PATCH] Fix leak on /proc/lockdep_stats
    • From: Alexey Dobriyan <[email protected]>

• References:
  • [PATCH] Fix leaks on /proc/{*/sched,sched_debug,timer_list,timer_stats}
    • From: Alexey Dobriyan <[email protected]>

• Prev by Date: Re: [2.6 patch] drivers/crypto/Kconfig: hardware drivers shouldn't "default m"
• Next by Date: Re: [patch-mm 01/33] clockevents: Remove unused inline function
• Previous by thread: [PATCH] Fix leaks on /proc/{*/sched,sched_debug,timer_list,timer_stats}
• Next by thread: [PATCH] Fix leak on /proc/lockdep_stats
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]