Re: [patch] CFS scheduler, -v19

[Ingo Molnar <mingo@elte.hu>]

* Ian Kent <raven@themaw.net> wrote:

> Yes it does and I have two reported bugs so far.
> 
> In several places I have code similar to:
> 
> wait.tv_sec = time(NULL) + 1;
> wait.tv_nsec = 0;
> 
> signaled = 0;
> while (!signaled) {
>         status = pthread_cond_timedwait(&cond, &mutex, &wait);
>        if (status) {
>              if (status == ETIMEDOUT)
>                   break;
>              fatal(status);
>       }
> }

ah! It passes in a low-res time source into a high-res time interface 
(pthread_cond_timedwait()). Could you change the time(NULL) + 1 to 
time(NULL) + 2, or change it to:

	gettimeofday(&wait, NULL);
	wait.tv_sec++;

does this solve the spinning?

i'm wondering how widespread this is. If automount is the only app doing 
this then _maybe_ we could get away with it by changing automount?

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/