Re: [PATCH 1/12] drivers/isdn/hisax/avm_pci.c: replace pci_find_device with pci_get_device

To be more clear, your solution is incorrect unless the pci_dev_put() occurs after the last reference to hw.{elsa,diva,hfc,njet,...}.dev, which is where the HiSax ISDN drivers store their reference to struct pci_dev during the runtime life of the PCI device.

Am I missing where your patch does this?

By way of further interest, a few hours _before_ (yes, really) I saw your patches, I resumed converting the ISDN HiSax PCI drivers to use the PCI driver API. You can find this work in git://git.kernel.org/.../jgarzik/misc-2.6.git#isdn-pci.

If you fix your patches' lifetime problems, I will ACK them myself, since my effort is a spare time effort. But just wanted you to be aware that I am deep into the code you are fixing, and can at least speak somewhat knowledgeably on the specific lines of code you are changing.

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 1/12] drivers/isdn/hisax/avm_pci.c: replace pci_find_device with pci_get_device
    • From: Surya Prabhakar N <[email protected]>

• References:
  • [PATCH 1/12] drivers/isdn/hisax/avm_pci.c: replace pci_find_device with pci_get_device
    • From: "S.Çağlar Onur" <[email protected]>
  • Re: [PATCH 1/12] drivers/isdn/hisax/avm_pci.c: replace pci_find_device with pci_get_device
    • From: Jeff Garzik <[email protected]>
  • Re: [PATCH 1/12] drivers/isdn/hisax/avm_pci.c: replace pci_find_device with pci_get_device
    • From: Jeff Garzik <[email protected]>

• Prev by Date: Re: [PATCH] remove PAGE_SIZE from headers_install
• Next by Date: Re: [PATCH] remove PAGE_SIZE from headers_install
• Previous by thread: Re: [PATCH 1/12] drivers/isdn/hisax/avm_pci.c: replace pci_find_device with pci_get_device
• Next by thread: Re: [PATCH 1/12] drivers/isdn/hisax/avm_pci.c: replace pci_find_device with pci_get_device
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]