Re: shmem: convert to using splice instead of sendfile()

On Tue, Jul 10 2007, Andrew Morton wrote:
> On Tue, 10 Jul 2007 23:00:59 GMT Linux Kernel Mailing List <[email protected]> wrote:
> 
> > +static int shmem_readpage(struct file *file, struct page *page)
> > +{
> > +	struct inode *inode = page->mapping->host;
> > +	int error = shmem_getpage(inode, page->index, &page, SGP_CACHE, NULL);
> > +	unlock_page(page);
> > +	return error;
> > +}
> 
> Worried.  shmem_getpage() does
> 
> done:
> 	if (*pagep != filepage) {
> 		unlock_page(filepage);
> 		*pagep = filepage;
> 	}
> 	return 0;
> 
> so we end up unlocking an unlocked page?

It certainly looks like it - Hugh?

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: shmem: convert to using splice instead of sendfile()
    • From: Hugh Dickins <[email protected]>

• References:
  • Re: shmem: convert to using splice instead of sendfile()
    • From: Andrew Morton <[email protected]>

• Prev by Date: Re: [EXT4 set 9][PATCH 4/5]Morecleanups:ext4_extent_compilation_fixes
• Next by Date: Re: [EXT4 set 9][PATCH 5/5]Extent micro cleanups
• Previous by thread: Re: shmem: convert to using splice instead of sendfile()
• Next by thread: Re: shmem: convert to using splice instead of sendfile()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]