Re: shmem: convert to using splice instead of sendfile()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Tue, 10 Jul 2007 23:00:59 GMT Linux Kernel Mailing List <[email protected]> wrote:

> +static int shmem_readpage(struct file *file, struct page *page)
> +{
> +	struct inode *inode = page->mapping->host;
> +	int error = shmem_getpage(inode, page->index, &page, SGP_CACHE, NULL);
> +	unlock_page(page);
> +	return error;
> +}

Worried.  shmem_getpage() does

	if (*pagep != filepage) {
		*pagep = filepage;
	return 0;

so we end up unlocking an unlocked page?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at
Please read the FAQ at

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux