Re: [PATCH] LinuxPPS (with new syscalls API) - new version

On Mon, 2007-07-09 at 15:19 +0200, Rodolfo Giometti wrote:
> 
> > Also read Documentation/volatile-considered-harmful.txt and ponder
> > deeply your use of 'volatile' on certain members of struct pps_s.
> 
> I read such document but I'm still convinced that the attribute
> volatile is needed for {assert,clear}_sequence and {assert,clear}_tu
> since inside pps_event() they are updated without any locks at all
> thanks to the dummy_info variable which is used for unallocated PPS
> sources.

I'm sure the version with 'volatile' will also be broken then. Sounds
like the right answer is to fix the locking.

-- 
dwmw2

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] LinuxPPS (with new syscalls API) - new version
    • From: Rodolfo Giometti <[email protected]>

• References:
  • Re: [PATCH] LinuxPPS (with new syscalls API) - new version
    • From: David Woodhouse <[email protected]>
  • Re: [PATCH] LinuxPPS (with new syscalls API) - new version
    • From: Rodolfo Giometti <[email protected]>
  • Re: [PATCH] LinuxPPS (with new syscalls API) - new version
    • From: David Woodhouse <[email protected]>
  • Re: [PATCH] LinuxPPS (with new syscalls API) - new version
    • From: Rodolfo Giometti <[email protected]>

• Prev by Date: [PATCH] fix sparse problems with ARRAY_SIZE
• Next by Date: Re: [PATCH 009 of 20] knfsd: nfsd: use ip-address-based domain in secinfo case
• Previous by thread: Re: [PATCH] LinuxPPS (with new syscalls API) - new version
• Next by thread: Re: [PATCH] LinuxPPS (with new syscalls API) - new version
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]