Re: [PATCH] mmc: at91_mci: fix hanging and rework to match flowcharts

[Mariusz Kozlowski <m.kozlowski@tuxland.pl>]

Hello,

> @@ -250,28 +246,27 @@ static void at91_mci_pre_dma_read(struct
>  /*
>   * Handle after a dma read
>   */
> -static void at91_mci_post_dma_read(struct at91mci_host *host)
> +static int at91_mci_post_dma_read(struct at91mci_host *host)
>  {
>         struct mmc_command *cmd;
>         struct mmc_data *data;
> +       int completed = 0;

You added 'completed' but you use it only once - as a return value.

>         pr_debug("post dma read done\n");
> +       return completed;
> }

What's the point?

	Mariusz
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/