Re: [PATCH] ALSA: use __devexit_p

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



At Sat, 23 Jun 2007 18:50:57 -0400,
Jeff Garzik wrote:
> 
> This reminds me...
> 
> Someone needs to go through ALSA and audit all delays executed via 
> $FOO_interruptible().
> 
> Several delays within ALSA wait for hardware conditions, and do not 
> check for signals pending, which means that the wait-for-condition loop 
> becomes a busy loop:
> 
> 	while (1) {
> 		foo = read_hardware()
> 		if (foo & interesting_bits)
> 			break;
> 		schedule_timeout_interruptible(1);
> 	}
> 
> The proper fix is (a) remove "_interruptible" [recommended] or (b) check 
> for signals.
> 
> grep'ing for "_interruptible" quickly finds several such ALSA bugs.

Yep...  I fixed now on ALSA tree.  Thanks for hints!


Takashi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux