Re: w1_therm_read_bin: suspicious usage of flush_signals()

On Thu, Jun 14, 2007 at 09:24:39PM +0400, Oleg Nesterov ([email protected]) wrote:
> drivers/w1/slaves/w1_therm.c:w1_therm_read_bin()
> 
> 	while (tm) {
> 		tm = msleep_interruptible(tm);
> 		if (signal_pending(current))
> 			flush_signals(current);
> 	}
> 
> current is user-space task, yes?
> 
> this looks just wrong, could you please explain?

Hi Oleg.

Well, it can be uninterruptible sleep, but why?
It is not allowed to return to userspace until transaction is completed,
so having uninterruptible sleep will result in exactly same lost of
signals.

> Oleg.

-- 
	Evgeniy Polyakov
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: w1_therm_read_bin: suspicious usage of flush_signals()
    • From: Roland McGrath <[email protected]>

• References:
  • w1_therm_read_bin: suspicious usage of flush_signals()
    • From: Oleg Nesterov <[email protected]>

• Prev by Date: Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
• Next by Date: Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
• Previous by thread: w1_therm_read_bin: suspicious usage of flush_signals()
• Next by thread: Re: w1_therm_read_bin: suspicious usage of flush_signals()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]