w1_therm_read_bin: suspicious usage of flush_signals()

drivers/w1/slaves/w1_therm.c:w1_therm_read_bin()

	while (tm) {
		tm = msleep_interruptible(tm);
		if (signal_pending(current))
			flush_signals(current);
	}

current is user-space task, yes?

this looks just wrong, could you please explain?

Oleg.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: w1_therm_read_bin: suspicious usage of flush_signals()
    • From: Evgeniy Polyakov <[email protected]>

• Prev by Date: [PATCH] adb_probe_task: remove unneeded flush_signals() call
• Next by Date: Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
• Previous by thread: [PATCH] adb_probe_task: remove unneeded flush_signals() call
• Next by thread: Re: w1_therm_read_bin: suspicious usage of flush_signals()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]