Re: [PATCH 1/18] splice: abstract out actor data

On Tue, 2007-06-12 at 18:22 +0200, Jens Axboe wrote:
> On Tue, Jun 12 2007, Eric Dumazet wrote:
> > On Tue, 12 Jun 2007 08:57:57 +0200
> > Jens Axboe <[email protected]> wrote:
> > 
> > 
> > > +	struct splice_desc sd = {
> > > +		.total_len = len,
> > > +		.flags = flags,
> > > +		.pos = *ppos,
> > > +	};
> > > +
> > > +	sd.file = out;
> > 
> > minor remark, why sd.file is setup differently than other fields ?
> > 
> > (this several times on this patch)
> 
> yeah, it's inside an anonymous union, and apparently gcc doesn't like it
> being initialized that way.

The one time I had such a situation something along the lines of:

struct splice_desc sd = {
	.total_len = len,
	.flags = flags,
	.pos = *ppos,
	{ .file = out },
};

worked.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 1/18] splice: abstract out actor data
    • From: Jens Axboe <[email protected]>

• References:
  • [PATCH 0/18] Convert sendfile to splice
    • From: Jens Axboe <[email protected]>
  • [PATCH 1/18] splice: abstract out actor data
    • From: Jens Axboe <[email protected]>
  • Re: [PATCH 1/18] splice: abstract out actor data
    • From: Eric Dumazet <[email protected]>
  • Re: [PATCH 1/18] splice: abstract out actor data
    • From: Jens Axboe <[email protected]>

• Prev by Date: Re: WARNING: at drivers/usb/core/urb.c:293 usb_submit_urb() [Was: 2.6.22-rc4-mm2]
• Next by Date: Runaway process and oom-killer
• Previous by thread: Re: [PATCH 1/18] splice: abstract out actor data
• Next by thread: Re: [PATCH 1/18] splice: abstract out actor data
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]