Re: [PATCH] fix improper .init-type section references

On 6/12/07, Satyam Sharma <[email protected]> wrote:

On 6/12/07, Jan Beulich <[email protected]> wrote:
[...]
> >I believe the correct fix to silence modpost here would be to mark its
> >caller kthreadd() also as __init, because it too is used only at init time?
>
> I don't think so - it is my understanding that this is the body of a thread
> that never dies.

Ugh, yes, I'm smoking God-knows-what, and you're absolutely correct!

So we should be marking kthreadd() as __init_refok instead, it seems.


Actually, kthreadd_setup() is a 4-liner with only one callsite. Not much
point marking it as __init. In fact, does it even need to be a separate
function at all? We could just get rid of kthreadd_setup() and open-code
those 4 lines in kthreadd() itself ...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

References:
- [PATCH] fix improper .init-type section references
  - From: "Jan Beulich" <[email protected]>
- Re: [PATCH] fix improper .init-type section references
  - From: "Satyam Sharma" <[email protected]>
- Re: [PATCH] fix improper .init-type section references
  - From: "Jan Beulich" <[email protected]>
- Re: [PATCH] fix improper .init-type section references
  - From: "Satyam Sharma" <[email protected]>

Prev by Date: [PATCH] atmel_lcdfb: Fix wrong line_length calculation
Next by Date: Re: Allow softlockup to be runtime disabled.
Previous by thread: Re: [PATCH] fix improper .init-type section references
Next by thread: [PATCH] page table handling cleanup
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]