Hi Jan,
On 6/12/07, Jan Beulich <[email protected]> wrote:
.. which modpost started warning about.
Signed-off-by: Jan Beulich <[email protected]>
kernel/kthread.c | 2 +-
mm/page_alloc.c | 18 +++++++++---------
2 files changed, 10 insertions(+), 10 deletions(-)
--- linux-2.6.22-rc4/kernel/kthread.c 2007-06-11 18:09:47.000000000 +0200
+++ 2.6.22-rc4-init-attribs/kernel/kthread.c 2007-06-11 09:10:42.000000000 +0200
@@ -215,7 +215,7 @@ int kthread_stop(struct task_struct *k)
EXPORT_SYMBOL(kthread_stop);
-static __init void kthreadd_setup(void)
+static noinline __init_refok void kthreadd_setup(void)
{
struct task_struct *tsk = current;
This isn't ok. There isn't any __init function that is (safely) referenced
by kthreadd_setup(), so we shouldn't really be marking it as such.
Also, kthreadd_setup() is really only ever called at init time, so we'd
want it to remain __init.
I believe the correct fix to silence modpost here would be to mark its
caller kthreadd() also as __init, because it too is used only at init time?
[ Cc:'ing Sam. ]
--- linux-2.6.22-rc4/mm/page_alloc.c 2007-06-11 18:09:49.000000000 +0200
+++ 2.6.22-rc4-init-attribs/mm/page_alloc.c 2007-06-11 09:10:42.000000000 +0200
@@ -126,13 +126,13 @@ static unsigned long __meminitdata dma_r
#endif
#endif
- struct node_active_region __meminitdata early_node_map[MAX_ACTIVE_REGIONS];
- int __meminitdata nr_nodemap_entries;
- unsigned long __meminitdata arch_zone_lowest_possible_pfn[MAX_NR_ZONES];
- unsigned long __meminitdata arch_zone_highest_possible_pfn[MAX_NR_ZONES];
+ static struct node_active_region __meminitdata early_node_map[MAX_ACTIVE_REGIONS];
+ static int __meminitdata nr_nodemap_entries;
+ static unsigned long __meminitdata arch_zone_lowest_possible_pfn[MAX_NR_ZONES];
+ static unsigned long __meminitdata arch_zone_highest_possible_pfn[MAX_NR_ZONES];
#ifdef CONFIG_MEMORY_HOTPLUG_RESERVE
- unsigned long __initdata node_boundary_start_pfn[MAX_NUMNODES];
- unsigned long __initdata node_boundary_end_pfn[MAX_NUMNODES];
+ static unsigned long __meminitdata node_boundary_start_pfn[MAX_NUMNODES];
+ static unsigned long __meminitdata node_boundary_end_pfn[MAX_NUMNODES];
Umm, can't really comment on mm/ code, but this could've been a
separate patch ... (the simple non-static to static conversions, at least)
Satyam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
