Re: generic bool and sparse errors?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Richard Knutsson wrote:
Kok, Auke wrote:
I'm experimenting with using the generic bool type and using sparse I get tons of these messages:

warning: incorrect type in argument 4 (different signedness)
    expected bool [unsigned] [usertype] *[unsigned] success
    got bool *<noident>

I'm not really worried about this, I assume that sparse hasn't caught up with what bool really means, but perhaps this can be looked into by someone who knows sparse well. The warnings don't really add up and with more people switching to use the generic bool this may beceome unwanted.
>
Actually, I am "assigned" to that. :)

ah cool

Just out of curiousity, where do you see those messages? In the log for allyesconfig on i386 I only found ntfs/super.c with similar output.

I was poking around replacing the boolean_t typedef in e1000, so it's nothing upstream. Just run `sed -i s/boolean_t/bool/g` on all the files in drivers/net/e1000 to see :)

the version of sparse is that in fc6, so that may be out-of-date (?).

alternatively we might need to reconsider the `typedef _Bool bool;` declaration and force it to be unsigned. I'm not sure what to think of that.
I do not see how that would make any sense.

well the sparse warning is about signedness. Either sparse needs to "know" that bool is unsigned, or the kernel headers need to somehow make bool unsigned... the latter choice would come down to just that, but it doesn't look like a good idea to me either somehow.

Auke
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux