Andrew Morton napsal(a):
> On Tue, 5 Jun 2007 23:20:57 +0200 (CEST)
> Jiri Slaby <[email protected]> wrote:
>
>> stallion, don't fail with less than max panels
>>
>
> Why not?
>
> What problem is this patch fixing, and how does it fix it?
>
> What are the consequences of not having this patch in the kernel?
>
> etc. More complete changlogs, please.
Aah, sorry.
--
Since it's not neccesary to have MAX_PANELS on the card, don't fail to let users
use this card even in this case. Stop the testing for loop instead.
--
>
>> diff --git a/drivers/char/stallion.c b/drivers/char/stallion.c
>> index e45113a..265abad 100644
>> --- a/drivers/char/stallion.c
>> +++ b/drivers/char/stallion.c
>> @@ -2172,7 +2172,7 @@ static int __devinit stl_initech(struct stlbrd *brdp)
>> }
>> status = inb(ioaddr + ECH_PNLSTATUS);
>> if ((status & ECH_PNLIDMASK) != nxtid)
>> - goto err_fr;
>> + break;
>> panelp = kzalloc(sizeof(struct stlpanel), GFP_KERNEL);
>> if (!panelp) {
>> printk("STALLION: failed to allocate memory "
>
thanks,
--
http://www.fi.muni.cz/~xslaby/ Jiri Slaby
faculty of informatics, masaryk university, brno, cz
e-mail: jirislaby gmail com, gpg pubkey fingerprint:
B674 9967 0407 CE62 ACC8 22A0 32CC 55C3 39D4 7A7E
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
