Re: [PATCH 7/8] Scanner changes needed to implement per-container scanner

[Pavel Emelianov <xemul@openvz.org>]

Balbir Singh wrote:
> Andrew Morton wrote:
>>> +		nr_reclaimed += shrink_zones(priority, zones, sc);
>>> +		if (sc->cnt == NULL)
>>> +			shrink_slab(sc->nr_scanned, gfp_mask, lru_pages);
>> We don't we shrink slab if called to shrink a container.
>>
>> This is a fundamental design decision, and a design shortcoming.  A full
>> discussion of this is absolutely appropriate to the patch changelog. 
>> Please don't just hide stuff like this in the patch and leave people
>> wondering, or ignorant.
> 
> Yes, we don't because we do not account for slab usage right now. We account
> only for memory allocated to user space. A good fat comment will help here.
> 
> 

I have already added the comment. But the problem is not in that we
do not account for kernel memory. Shrinking slabs won't unmap any
pages from user-space and thus won't help user to charge more. This
will only make kernel suffer from re-creation of objects.

Thanks,
Pavel.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/