Re: [PATCH 7/8] Scanner changes needed to implement per-container scanner

Andrew Morton wrote:
> 
>> +		nr_reclaimed += shrink_zones(priority, zones, sc);
>> +		if (sc->cnt == NULL)
>> +			shrink_slab(sc->nr_scanned, gfp_mask, lru_pages);
> 
> We don't we shrink slab if called to shrink a container.
> 
> This is a fundamental design decision, and a design shortcoming.  A full
> discussion of this is absolutely appropriate to the patch changelog. 
> Please don't just hide stuff like this in the patch and leave people
> wondering, or ignorant.

Yes, we don't because we do not account for slab usage right now. We account
only for memory allocated to user space. A good fat comment will help here.


-- 
	Warm Regards,
	Balbir Singh
	Linux Technology Center
	IBM, ISTL
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 7/8] Scanner changes needed to implement per-container scanner
    • From: Pavel Emelianov <[email protected]>

• References:
  • [PATCH 0/8] RSS controller based on process containers (v3)
    • From: Pavel Emelianov <[email protected]>
  • [PATCH 7/8] Scanner changes needed to implement per-container scanner
    • From: Pavel Emelianov <[email protected]>
  • Re: [PATCH 7/8] Scanner changes needed to implement per-container scanner
    • From: Andrew Morton <[email protected]>

• Prev by Date: Re: Patch related with Fork Bombing Atack
• Next by Date: Re: [PATCH] Make prepare_namespace() wait for devices
• Previous by thread: Re: [PATCH 7/8] Scanner changes needed to implement per-container scanner
• Next by thread: Re: [PATCH 7/8] Scanner changes needed to implement per-container scanner
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]