On Thu, 31 May 2007 16:20:21 -0700 Andrew Morton <[email protected]> wrote: > > > diff --git a/include/asm-generic/fcntl.h b/include/asm-generic/fcntl.h > > index c154b9d..b847741 100644 > > --- a/include/asm-generic/fcntl.h > > +++ b/include/asm-generic/fcntl.h > > @@ -48,6 +48,9 @@ > > #ifndef O_NOATIME > > #define O_NOATIME 01000000 > > #endif > > +#ifndef O_CLOEXEC > > +#define O_CLOEXEC 02000000 /* set close_on_exec */ > > +#endif > > #ifndef O_NDELAY > > #define O_NDELAY O_NONBLOCK > > #endif > > This will break xtensa, because that architecture (and only that > architecture) doesn't include asm-generic/fcntl.h from asm/fcntl.h. This also breaks Alpha (which uses 02000000 for O_DIRECT) and parisc (which uses 02000000 for O_RSYNC). So you ether need to choose a different value or define O_CLOEXEC for those two architectures. -- Cheers, Stephen Rothwell [email protected] http://www.canb.auug.org.au/~sfr/
Attachment:
pgpFs1TI7I6Jo.pgp
Description: PGP signature
- Follow-Ups:
- Re: [PATCH] Introduce O_CLOEXEC (take >2)
- From: Kyle McMartin <[email protected]>
- Re: [PATCH] Introduce O_CLOEXEC (take >2)
- References:
- [PATCH] Introduce O_CLOEXEC (take >2)
- From: Ulrich Drepper <[email protected]>
- Re: [PATCH] Introduce O_CLOEXEC (take >2)
- From: Andrew Morton <[email protected]>
- [PATCH] Introduce O_CLOEXEC (take >2)
- Prev by Date: Re: Linux v2.6.22-rc3
- Next by Date: Re: [PATCH] Input: document the proper usage of EV_KEY and KEY_UNKNOWN
- Previous by thread: Re: [PATCH] Introduce O_CLOEXEC (take >2)
- Next by thread: Re: [PATCH] Introduce O_CLOEXEC (take >2)
- Index(es):
 |