Re: [PATCH 1/3] hexdump: more output formatting

Christoph Lameter wrote:

On Wed, 30 May 2007, Randy Dunlap wrote:

Add an "ascii" output parameter.  This causes ASCII data output
following the hex data output.

The ascii output is not properly aligned. Its simply thrown in
after the hex dump output. The last line of a multi line hexdump
will have the ascii output moved to the left. Its not properly adjusted.

It was never a written requirement.  :)
but maybe it is now.

+ *
  * E.g.:
  *   print_hex_dump(KERN_DEBUG, DUMP_PREFIX_ADDRESS, frame->data, frame->len);

^^^ needs to be updated?

Yes, it does.


--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • 2.6.22-rc2-mm1
    • From: Andrew Morton <[email protected]>
  • Re: 2.6.22-rc2-mm1
    • From: Michal Piotrowski <[email protected]>
  • Re: 2.6.22-rc2-mm1
    • From: Christoph Lameter <[email protected]>
  • Re: 2.6.22-rc2-mm1
    • From: Michal Piotrowski <[email protected]>
  • Re: 2.6.22-rc2-mm1
    • From: Andrew Morton <[email protected]>
  • Re: 2.6.22-rc2-mm1
    • From: Christoph Lameter <[email protected]>
  • Re: 2.6.22-rc2-mm1
    • From: Andrew Morton <[email protected]>
  • Re: 2.6.22-rc2-mm1
    • From: Christoph Lameter <[email protected]>
  • Re: 2.6.22-rc2-mm1
    • From: Randy Dunlap <[email protected]>
  • Re: 2.6.22-rc2-mm1
    • From: Christoph Lameter <[email protected]>
  • Re: 2.6.22-rc2-mm1
    • From: Ingo Molnar <[email protected]>
  • Re: 2.6.22-rc2-mm1
    • From: Christoph Lameter <[email protected]>
  • Re: 2.6.22-rc2-mm1
    • From: Andrew Morton <[email protected]>
  • Re: 2.6.22-rc2-mm1
    • From: Randy Dunlap <[email protected]>
  • Re: 2.6.22-rc2-mm1
    • From: Christoph Lameter <[email protected]>
  • [PATCH 1/3] hexdump: more output formatting
    • From: Randy Dunlap <[email protected]>
  • Re: [PATCH 1/3] hexdump: more output formatting
    • From: Christoph Lameter <[email protected]>

• Prev by Date: Re: [PATCH 3/8] Add container pointer on mm_struct
• Next by Date: Re: [PATCH 4/8] RSS container core
• Previous by thread: Re: [PATCH 1/3] hexdump: more output formatting
• Next by thread: [PATCH 1/3 v2] hexdump: more output formatting
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]