Re: [PATCH 1/3] hexdump: more output formatting

[Christoph Lameter <clameter@sgi.com>]

On Wed, 30 May 2007, Randy Dunlap wrote:

> Add an "ascii" output parameter.  This causes ASCII data output
> following the hex data output.

The ascii output is not properly aligned. Its simply thrown in
after the hex dump output. The last line of a multi line hexdump
will have the ascii output moved to the left. Its not properly adjusted.

> + *
>   * E.g.:
>   *   print_hex_dump(KERN_DEBUG, DUMP_PREFIX_ADDRESS, frame->data, frame->len);

^^^ needs to be updated?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/