Moves quiesce, thread and interrupt shutdown into aacraid drivers' .shutdown handler. This fix to the aac_shutdown handler will remove the superfluous reset of the adapter during a (clean) kexec. This fix may mitigate the active investigation 'kexec and aacraid broken' but it is unlikely to affect the root cause (issue likely present in both kexec and kdump). This patch reduces the chance the problem will occur with a kexec. The fix for root cause is currently expected to be the minimum value check to the aacraid.startup_timeout driver variable after an adapter reset within aacraid_commit_reset.patch submitted on 05/22/2007 and awaiting testing by Yinghai to confirm. This attached patch is against current scsi-misc-2.6 ObligatoryDisclaimer: Please accept my condolences regarding Outlook's handling of patch attachments. Signed-off-by: Mark Salyzyn <[email protected]> Sincerely -- Mark Salyzyn > -----Original Message----- > From: [email protected] > [mailto:[email protected]] On Behalf Of Salyzyn, Mark > Sent: Wednesday, May 30, 2007 10:31 AM > To: [email protected] > Cc: Andrew Morton; Yinghai Lu; Eric W. Biederman; Linux > Kernel Mailing List; [email protected]; Michal Piotrowski > Subject: RE: kexec and aacraid broken > > Vivek Goyal [mailto:[email protected]] writes: > > So most likely if we start disabling the interrupts > > in .shutdown routine we might skip resetting adapter > > on every kexec without any side affects? > > Not that simple. The .shutdown would need to perform more resource > cleanups of the .remove call to prevent side effects. I need to move > some of the .remove activity into the .shutdown handler to > make sure the > adapter is quiesced. > > I will hold off on submitting any of these changes until they are > evaluated and tested; I am waiting for feedback from Yinghai on the > other mitigations that I feel are closer to the root cause. > > Sincerely -- Mark Salyzyn
Attachment:
aacraid_shutdown.patch
Description: aacraid_shutdown.patch
- Follow-Ups:
- Re: [PATCH] aacraid: fix shutdown handler to also disable interrupts.
- From: Vivek Goyal <[email protected]>
- Re: [PATCH] aacraid: fix shutdown handler to also disable interrupts.
- From: "Yinghai Lu" <[email protected]>
- Re: [PATCH] aacraid: fix shutdown handler to also disable interrupts.
- References:
- RE: kexec and aacraid broken
- From: "Salyzyn, Mark" <[email protected]>
- RE: kexec and aacraid broken
- Prev by Date: Re: add_timer_on and CONFIG_NO_HZ
- Next by Date: Re: pcmcia resume 60 second hang. Re: [patch 00/69] -stable review
- Previous by thread: RE: kexec and aacraid broken
- Next by thread: Re: [PATCH] aacraid: fix shutdown handler to also disable interrupts.
- Index(es):
 |