Re: JFFS2 using 'private' zlib header (was [RFC] LZO de/compression support - take 6)

[Daniel Hazelton <dhazelton@enter.net>]

On Tuesday 29 May 2007 09:33:51 Michael-Luke Jones wrote:
> On 29 May 2007, at 12:27, Satyam Sharma wrote:
> > Right, actually, zlib could be switched over to [using a common
> > directory].
> > Because zlib_deflate/ and zlib_inflate/ too share a private header
> > zutil.h which has unfortunately been stuck into include/linux/ with
> > a big
> > /* WARNING: this file should *not* be used by applications. */
> > comment ...
>
> Well, unfortunately zutil.h is currently being used in-kernel by fs/
> jffs2/compr_zlib.c despite the "WARNING: this file should *not* be
> used by applications" notice.
>
> So moving this header to a truly private location isn't possible
> right now, unfortunately,
>
> Michael-Luke Jones
> [added David Whitehouse to cc]

I've looked at that code and it seems to need that file for one constant. 
Perhaps it'd be better for jffs2/compr_zlib.c to define that constant itself 
(or use it as a "Magic Number") rather than include the zlib private header. 
Another possibility would be to move that constant out of zutil.h and into 
zconf.h or zlih.b - doing any of those would allow the zlib private header to 
be moved such that zlib could be changed to use a common directory *and* have 
said private header in that directory.

DRH


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/