Re: [PATCH 2/2] [AGPGART] intel_agp: use table for device probe

On 2007.05.29 10:18:48 +0000, Christoph Hellwig wrote:
> On Tue, May 29, 2007 at 02:21:25PM +0800, Wang Zhenyu wrote:
> > +static const struct intel_driver_description {
> > +	unsigned int chip_id;
> > +	unsigned int gmch_chip_id;
> > +	char *name;
> > +	struct agp_bridge_driver *driver;
> > +	struct agp_bridge_driver *gmch_driver;
> 
> The two should be const to avoid the silly casts below.
> 
> > +	for (i = 0; intel_agp_chipsets[i].name != NULL; i++) {
> > +		if (pdev->device == intel_agp_chipsets[i].chip_id)
> > +		    break;
> 
> please use tabs for indentation.
> 

I'll fix those problems in next submit, thank you for review. 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 2/2] [AGPGART] intel_agp: use table for device probe
    • From: Wang Zhenyu <[email protected]>
  • Re: [PATCH 2/2] [AGPGART] intel_agp: use table for device probe
    • From: Christoph Hellwig <[email protected]>

• Prev by Date: Re: Seeding /dev/random not working
• Next by Date: Re: JFFS2 using 'private' zlib header (was [RFC] LZO de/compression support - take 6)
• Previous by thread: Re: [PATCH 2/2] [AGPGART] intel_agp: use table for device probe
• Next by thread: [PATCH] binfmt_flat: minimum support for the Blackfin relocations
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]