Re: [PATCH - 1/1] Documentation/HOWTO

[Qi Yong <qiyong@fc-cn.com>]

On Thu, May 24, 2007 at 08:49:12AM -0700, Linus Torvalds wrote:
> 
> 
> On Thu, 24 May 2007, Diego Calleja wrote:
> > El Thu, 24 May 2007 17:45:04 +0800, "Qi Yong" <qiyong@fc-cn.com> escribió:
> > 
> > D'oh, it seems the patch was picked from the mailing list and merged twice,
> > and I didn't notice it.
> > 
> > > Torvalds, Care to revert one commit?
> > 
> > Agreed, one of them can be removed.
> 
> Yes, done.
> 
> Andrew - can you check that it's also removed from your queues, since it 
> might be there still just because it keeps applying cleanly.

People's fault, not tools'.

> 
> You might have it described as "HOWTO: mention bughunting" rather than 
> "HOWTO: bug report addition".
> 
> 		Linus

Sorry, my previous comment was not accurate.  The two patches are different,
not identical:


diff -u howto-mention-bughunting howto-bug-report-addition 
--- howto-mention-bughunting	2007-05-25 09:12:47.513596296 +0800
+++ howto-bug-report-addition	2007-05-25 09:12:58.914245983 +0800
@@ -1,7 +1,7 @@
 --- a/Documentation/HOWTO
 +++ b/Documentation/HOWTO
-@@ -375,6 +375,26 @@ of information is needed by the kernel developers to help track down the
- problem.
+@@ -395,6 +395,26 @@ bugme-janitor mailing list (every change in the bugzilla is mailed here)
+ 
  
  
 +Managing bug reports
@@ -11,7 +11,7 @@
 +bugs reported by other people. Not only you will help to make the kernel
 +more stable, you'll learn to fix real world problems and you will improve
 +your skills, and other developers will be aware of your presence. Fixing
-+bugs is one of the best ways to earn merit amongst the developers, because
++bugs is one of the best ways to get merits among other developers, because
 +not many people like wasting time fixing other people's bugs.
 +
 +To work in the already reported bug reports, go to http://bugzilla.kernel.org.


The second patch howto-bug-report-addition was an improvement, but was made
wrongly, thus added the duplication.

We should go with howto-bug-report-addition. Please take this:

Signed-off-by: Qi Yong <qiyong@fc-cn.com>
---

diff --git a/Documentation/HOWTO b/Documentation/HOWTO
index ced9207..f5e1b6d 100644
--- a/Documentation/HOWTO
+++ b/Documentation/HOWTO
@@ -383,7 +383,7 @@ One of the best ways to put into practice your hacking skills is by fixing
 bugs reported by other people. Not only you will help to make the kernel
 more stable, you'll learn to fix real world problems and you will improve
 your skills, and other developers will be aware of your presence. Fixing
-bugs is one of the best ways to earn merit amongst the developers, because
+bugs is one of the best ways to get merits among other developers, because
 not many people like wasting time fixing other people's bugs.
 
 To work in the already reported bug reports, go to http://bugzilla.kernel.org.


-- 
Qi Yong

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/