Re: [patch] sched_clock(): cleanups

[Andi Kleen <andi@firstfloor.org>]

On Fri, May 25, 2007 at 09:26:41AM +0200, Ingo Molnar wrote:
> 
> > > if (!f)
> > > 	f = cpufreq_get(freq->cpu);
> > > if (!f)
> > > 	f = tsc_khz;
> > > 
> > > ?
> > > 
> > > Something's not quite right here :-)
> 
> ah, that's fine. It does this: 'try to give f a value', and then: 'if 
> still no value then give it tsc_khz as a last resort)
> 
> call_r_s_f() still needs an urgent rerenaming though =B-)

The whole thing would be much simpler if

- cpu up callbacks had a way to request executing on the target CPU
[i looked at this, but it was a little more involved than a simple
cleanup]
- smp_call_function_single had sane semantics regarding calling
the same CPU similar to on_each_cpu()
- C had anonymous lambda functions with nice syntax (ok one can dream) 

But right now so many callbacks are needed that I ran out of good
names.

-Andi

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/