Re: [2.6 patch] drivers/net/wireless/libertas/rx.c: fix use-after-free

On Sat, May 19, 2007 at 11:14:10AM +0800, Eugene Teo wrote:
> John W. Linville wrote:

> >>  done:
> >>         LEAVE();
> >>
> >> -       skb->protocol = __constant_htons(0x0019);       /* ETH_P_80211_RAW */
> >> -
> > 
> > Except for this part...is this intentional?
> 
> skb could have been freed by then. And, in libertas_upload_rx_packet(), skb->protocol
> is initialized by eth_type_trans(skb, priv->wlan_dev.netdev).

OK, I see that.  Looks like Florin has reposted his patch, still
without this hunk.  Would you like to submit a patch for this hunk?

Thanks,

John
-- 
John W. Linville
[email protected]
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- Re: [2.6 patch] drivers/net/wireless/libertas/rx.c: fix use-after-free
  - From: Eugene Teo <[email protected]>

References:
- [2.6 patch] drivers/net/wireless/libertas/rx.c: fix use-after-free
  - From: Eugene Teo <[email protected]>
- Re: [2.6 patch] drivers/net/wireless/libertas/rx.c: fix use-after-free
  - From: "John W. Linville" <[email protected]>
- Re: [2.6 patch] drivers/net/wireless/libertas/rx.c: fix use-after-free
  - From: Eugene Teo <[email protected]>

Prev by Date: Re: signals logged / [RFC] log out-of-virtual-memory events
Next by Date: Re: [PATCH] 2.6.21: nfs_readpages: Add missing braces
Previous by thread: Re: [2.6 patch] drivers/net/wireless/libertas/rx.c: fix use-after-free
Next by thread: Re: [2.6 patch] drivers/net/wireless/libertas/rx.c: fix use-after-free
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]