Re: [2.6 patch] drivers/net/wireless/libertas/rx.c: fix use-after-free

First, please send all wireless patches to
[email protected], and be sure to CC me as well...thanks!

On Sat, May 19, 2007 at 12:50:31AM +0800, Eugene Teo wrote:
> libertas_upload_rx_packet() calls netif_rx() before returning, and it always return 0.
> Also within libertas_upload_rx_packet(), it will initialize skb->protocol anyways.
> 
> Spotted by the Coverity checker.

A nearly identical patch was posted by Florin Malita <[email protected]>
to netdev (also the wrong list) on Wednesday evening.

>  done:
>         LEAVE();
> 
> -       skb->protocol = __constant_htons(0x0019);       /* ETH_P_80211_RAW */
> -

Except for this part...is this intentional?

John
-- 
John W. Linville
[email protected]
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [2.6 patch] drivers/net/wireless/libertas/rx.c: fix use-after-free
    • From: Eugene Teo <[email protected]>

• References:
  • [2.6 patch] drivers/net/wireless/libertas/rx.c: fix use-after-free
    • From: Eugene Teo <[email protected]>

• Prev by Date: Re: [2.6 patch] drivers/net/wireless/libertas/fw.c: fix use-before-check
• Next by Date: Re: [patch] x86_64, irq: check remote IRR bit before migrating level triggered irq
• Previous by thread: [2.6 patch] drivers/net/wireless/libertas/rx.c: fix use-after-free
• Next by thread: Re: [2.6 patch] drivers/net/wireless/libertas/rx.c: fix use-after-free
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]