Re: [2.6 patch] net/llc/llc_conn.c: fix possible NULL dereference

From: Eugene Teo <[email protected]>
Date: Sat, 19 May 2007 13:13:07 +0800

> skb_peek() might return an empty list. skb should be checked before calling
> llc_pdu_sn_hdr() with it.
> 
> Spotted by the Coverity checker.
> 
> Signed-off-by: Eugene Teo <[email protected]>

The code checks skb_queue_len() for zero first, therefore NULL is
impossible.

Can you check this kind of stuff before submitting patches like this?

Thank you.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

References:
- [2.6 patch] net/llc/llc_conn.c: fix possible NULL dereference
  - From: Eugene Teo <[email protected]>

Prev by Date: Re: 2.6.22-rc1 does not boot on VIA C3_2 cause of X86_CMPXCHG64 II
Next by Date: Re: [2.6 patch] net/llc/llc_conn.c: fix possible NULL dereference
Previous by thread: Re: [2.6 patch] net/llc/llc_conn.c: fix possible NULL dereference
Next by thread: [PATCH] update dontdiff file
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]