Re: [PATCH] ubi: kill homegrown endian macros

[matthieu castet <castet.matthieu@free.fr>]

David Woodhouse wrote:
> On Thu, 2007-05-17 at 20:30 +0000, Matthieu CASTET wrote:
> > On Thu, 17 May 2007 10:29:31 -0700, Andrew Morton wrote:
> >
> > > On Thu, 17 May 2007 18:09:50 +0300 Artem Bityutskiy
> When I tested this on ARM, the output for je32_to_cpu et al was fine.
> For _other_ structures where I'd used __attribute__((packed)) to be
> safe, gcc would emit code to handle unaligned loads. But not in the
> simple case where the struct has only one member.
I don't think it is true.

When porting some summary stuff to bootloader, I hit some unaligned 
access problem :
in summary.c:405 there is a
switch (je16_to_cpu(((struct jffs2_sum_unknown_flash *)sp)->nodetype)) {
and
struct jffs2_sum_unknown_flash
{
    jint16_t nodetype;  /* node type */
};

note that sp isn't aligned to a 32 bits boundary (it can be anything and 
depend for example of the size of the dirent name).

if gcc doesn't emit code to handle unaligned loads in this case, there 
is unaligned access.

When compiling my code for arm, I use a gcc-4.1.1 with a bug and it 
break. With another compiler (last gcc from codesourcery) it worked 
(because gcc emit load it bit per bit).


> Are you suggesting that this has changed since I did my testing?
Which version of gcc did you try ?

Matthieu
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/