Re: [RFC][PATCH 2/14] Add a new mount flag (MNT_UNION) for union mount

[Bharata B Rao <bharata@linux.vnet.ibm.com>]

On Mon, May 14, 2007 at 10:38:46PM +0200, Jan Engelhardt wrote:
> 
> On May 14 2007 15:09, Bharata B Rao wrote:
> >
> >Introduce MNT_UNION, MS_UNION and FS_WHT flags. There are the necessary flags
> >for doing
> >
> >    mount /dev/hda3 /mnt -o union
> >
> >You need additional patches for util-linux for that to work.
> >
> >Signed-off-by: Jan Blunck <j.blunck@tu-harburg.de>
> >Signed-off-by: Bharata B Rao <bharata@linux.vnet.ibm.com>
> >---
> > 
> >+	/* Unions couldn't be writable if the filesystem
> >+	 * doesn't know about whiteouts */
> >+	err = -ENOTSUPP;
> >+	if ((mnt_flags & MNT_UNION) &&
> >+	    !(newmnt->mnt_sb->s_flags & MS_RDONLY) &&
> >+	    !(newmnt->mnt_sb->s_type->fs_flags & FS_WHT))
> >+		goto unlock;
> >+
> 
> Maybe I am too biased towards unionfs/aufs, but if I have an {rw,rw} union
> with whiteouts disabled (delete=all in unionfs speak), then FS_WHT
> does not need to be supported. Your patches do not seem to do
> delete=all semantics, do they?
> 

No, they don't support delete=all semantics.

Correct me if I am wrong, but a key difference from unionfs is that in
union mounts only the topmost layer is writable (and it doesn't matter if
the lower layers are mounted rw), while this not so with unionfs.
Hence when we delete any file which is present in a lower layer, we create
a whiteout for it on the topmost layer to mask it out.

So there can be two cases in union mounts:
1. A file exists in topmost layer and also in one or more lower layers. Deleting
the file would result in the top layer file being deleted and a whiteout being
created in the top layer.

2. A file exists in one or more of lower layers, but not in the topmost layer.
Deleting this file would result in just a whiteout being created in the
topmost layer.

Regards,
Bharata.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/