Re: [PATCH] serial: set RTS and DTR if flow is 'r' --- resend

Russell King wrote:

There may be some sense, however, in allowing DTR to be permanently
raised for serial consoles.  However, I would err on caution since
DTR is used to reliably instruct modems to drop the line, so making
such a change would be undesirable for those folk.

please check following is OK.

YH

[PATCH] serial: set DTR in uart for kernel serial console

Some UARTs on other side need host uart DTR is set, otherwise will not receive char from the host that kernel is runing during kernel boot stage.

BTW:
earlyprintk and early_uart are hard coded to set DTR/RTS.

Signed-off-by: Yinghai Lu <[email protected]>
Cc: Russell King <[email protected]>
Cc: Andi Kleen <[email protected]>
Cc: Bjorn Helgaas <[email protected]>

*diff --git a/drivers/serial/8250.c b/drivers/serial/8250.c*
index 48e259a..29c051c 100644
*--- a/drivers/serial/8250.c*
*+++ b/drivers/serial/8250.c*
@@ -2154,6 +2154,12 @@ serial8250_set_termios(struct uart_port *port, struct ktermios *termios,
		}
		serial_outp(up, UART_FCR, fcr);		/* set fcr */
	}
+
+	/* some uarts on other side don't support no flow control. So we set
+	 * DTR in host uart to make them happy
+	 */
+	up->port.mctrl |= TIOCM_DTR;
+
	serial8250_set_mctrl(&up->port, up->port.mctrl);
	spin_unlock_irqrestore(&up->port.lock, flags);
}

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • [PATCH] serial: set DTR in uart for kernel serial console
    • From: Yinghai Lu <[email protected]>
  • Re: [PATCH] serial: set RTS and DTR if flow is 'r' --- resend
    • From: Russell King <[email protected]>

• References:
  • [PATCH]x86_64: build and use GDT on copied compressed kernel
    • From: "Yinghai Lu" <[email protected]>
  • Re: [PATCH]x86_64: build and use GDT on copied compressed kernel
    • From: [email protected] (Eric W. Biederman)
  • [PATCH] serial: set RTS and DTR if flow is 'r'
    • From: Yinghai Lu <[email protected]>
  • [PATCH] serial: set RTS and DTR if flow is 'r' --- resend
    • From: Yinghai Lu <[email protected]>
  • Re: [PATCH] serial: set RTS and DTR if flow is 'r' --- resend
    • From: Russell King <[email protected]>

• Prev by Date: Re: [PATCH][RFC] Remove final vestiges of interrupt-related "SA_" flags.
• Next by Date: RE: [PATCH] cciss: Fix pci_driver.shutdown while device is still active
• Previous by thread: Re: [PATCH] serial: set RTS and DTR if flow is 'r' --- resend
• Next by thread: Re: [PATCH] serial: set RTS and DTR if flow is 'r' --- resend
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]