Re: [PATCH] libata: fallback to the other IDENTIFY on device error, take#2

[Dave Jones <davej@redhat.com>]

On Sun, May 13, 2007 at 07:50:16PM +0200, Tejun Heo wrote:
 > > Otherwise, as Jeff mentions, you're doing a redundant assignment
 > > in the else branch.
 > 
 > Hmmm... I'm feeling very dense today.  At that point, class is either
 > ATA_DEV_ATA or ATA_DEV_ATAPI.  The if-else clause tries to flip between
 > the two.
 > 
 > 1. if class == ATA_DEV_ATA, the 'if' test succeeds and "class =
 > ATA_DEV_ATAPI" runs, so it flips correctly.
 > 
 > 2. if class == ATA_DEV_ATAPI,  the 'if' test fails and "class =
 > ATA_DEV_ATA" runs, so it flips correctly.
 > 
 > What am I missing here?  Feel free to scream at me and hammer me into
 > senses.  :-)

actually, I think I'm denser today. Ignore that last mail.

	Dave

-- 
http://www.codemonkey.org.uk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/