Re: [PATCH] libata: fallback to the other IDENTIFY on device error, take#2

Jeff Garzik wrote:
> Tejun Heo wrote:
>> +            if (class == ATA_DEV_ATA)
>> +                class = ATA_DEV_ATAPI;
>> +            else
>> +                class = ATA_DEV_ATA;
> 
> 
> the 'else' branch is obviously redundant

Why?  We can also fallback from ATAPI to ATA.

-- 
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] libata: fallback to the other IDENTIFY on device error, take#2
    • From: Dave Jones <[email protected]>

• References:
  • 2.6.20 libata cdrom
    • From: William Thompson <[email protected]>
  • Re: 2.6.20 libata cdrom
    • From: Tejun Heo <[email protected]>
  • Re: 2.6.20 libata cdrom
    • From: William Thompson <[email protected]>
  • Re: 2.6.20 libata cdrom
    • From: Tejun Heo <[email protected]>
  • Re: 2.6.20 libata cdrom
    • From: William Thompson <[email protected]>
  • Re: 2.6.20 libata cdrom
    • From: Mark Lord <[email protected]>
  • Re: 2.6.20 libata cdrom
    • From: William Thompson <[email protected]>
  • Re: 2.6.20 libata cdrom
    • From: Tejun Heo <[email protected]>
  • Re: 2.6.20 libata cdrom
    • From: William Thompson <[email protected]>
  • [PATCH] libata: fallback to the other IDENTIFY on device error
    • From: Tejun Heo <[email protected]>
  • Re: [PATCH] libata: fallback to the other IDENTIFY on device error
    • From: Jeff Garzik <[email protected]>
  • [PATCH] libata: fallback to the other IDENTIFY on device error, take#2
    • From: Tejun Heo <[email protected]>
  • Re: [PATCH] libata: fallback to the other IDENTIFY on device error, take#2
    • From: Jeff Garzik <[email protected]>

• Prev by Date: Re: [PATCH] make cancel_rearming_delayed_work() reliable
• Next by Date: Re: [PATCH] Add LZO1X compression support to the kernel
• Previous by thread: Re: [PATCH] libata: fallback to the other IDENTIFY on device error, take#2
• Next by thread: Re: [PATCH] libata: fallback to the other IDENTIFY on device error, take#2
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]