On Wed, 09 May 2007 10:07:56 PDT, Christoph Lameter said: > On Wed, 9 May 2007, [email protected] wrote: > > 1) Spotted in init/Kconfig: > > > > config SLUB_DEBUG > > default y > > bool "Enable SLUB debugging support" if EMBEDDED > > help > > > > Shouldn't that have an 'default SLUB' or 'if SLUB' or something attached to it? > > Maybe. Is there a problem with SLUB_DEBUG being set if SLUB is not > selected? % egrep 'SL[AU]B' /usr/src/linux-2.6.21-mm2/.config # CONFIG_SLUB_DEBUG is not set CONFIG_SLAB=y # CONFIG_SLUB is not set # CONFIG_DEBUG_SLAB is not set Just seemed odd to do a 'make oldconfig' and get prompted for the value, and it gave a value of 'Y' to a debug option of a feature that wasn't selected. :) It took me a while to convince myself that somebody hadn't changed the default to CONFIG_SLUB while I wasn't looking.... (Maybe the order of entries needs fixing - SLAB, SLAB_DEBUG, SLUB, SLUB_DEBUG, so that oldconfig and friends don't pop the question for debugging till *after* they ask if the feature should be included?
Attachment:
pgpxi6NgIFkww.pgp
Description: PGP signature
- Follow-Ups:
- Re: 2.6.21-mm2 - Kconfig horkage
- From: Christoph Lameter <[email protected]>
- Re: 2.6.21-mm2 - Kconfig horkage
- References:
- 2.6.21-mm2
- From: Andrew Morton <[email protected]>
- Re: 2.6.21-mm2 - Kconfig horkage
- From: [email protected]
- Re: 2.6.21-mm2 - Kconfig horkage
- From: Christoph Lameter <[email protected]>
- 2.6.21-mm2
- Prev by Date: Re: [PATCH] stub MADV_FREE implementation
- Next by Date: Section mismatch warnings (was Re: [PATCH] early_pfn_to_nid needs to be __meminit)
- Previous by thread: Re: 2.6.21-mm2 - Kconfig horkage
- Next by thread: Re: 2.6.21-mm2 - Kconfig horkage
- Index(es):
 |