Re: [PATCH -mm] PM: Separate hibernation code from suspend code

On Mon, 2007-05-07 at 23:35 +0200, Rafael J. Wysocki wrote:

> > Also, you could then simplify all the instances of
> >   (hibernation_mode == HIBERNATION_PLATFORM && hibernation_ops) 
> > to just
> >   (hibernation_mode == HIBERNATION_PLATFORM)
> > in various if statements and other places.
> 
> No, that's not a good idea, because of the "reduce code duplication patch"
> that I'd like to go on top of this.  I'd rather use 'if (hibernation_ops)' here. :-)

But if you want the user to be able to change away from 'platform' mode
you still have to have
  if (hibernation_ops && hibernation_mode == HIBERNATION_PLATFORM)
in most places, no?

johannes

Attachment: signature.asc
Description: This is a digitally signed message part

Follow-Ups:
- Re: [PATCH -mm] PM: Separate hibernation code from suspend code
  - From: "Rafael J. Wysocki" <[email protected]>

References:
- [PATCH -mm] PM: Separate hibernation code from suspend code
  - From: "Rafael J. Wysocki" <[email protected]>
- Re: [PATCH -mm] PM: Separate hibernation code from suspend code
  - From: Johannes Berg <[email protected]>
- Re: [PATCH -mm] PM: Separate hibernation code from suspend code
  - From: Johannes Berg <[email protected]>
- Re: [PATCH -mm] PM: Separate hibernation code from suspend code
  - From: "Rafael J. Wysocki" <[email protected]>

Prev by Date: Re: sleeping function called from invalid context at block/cfq-iosched.c (Was: Re: 2.6.21-mm1)
Next by Date: Re: Long file names in VFAT broken with iocharset=utf8
Previous by thread: Re: [PATCH -mm] PM: Separate hibernation code from suspend code
Next by thread: Re: [PATCH -mm] PM: Separate hibernation code from suspend code
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]