Re: [PATCH -mm] PM: Separate hibernation code from suspend code

[Johannes Berg <johannes@sipsolutions.net>]

On Mon, 2007-05-07 at 23:35 +0200, Rafael J. Wysocki wrote:

> > Also, you could then simplify all the instances of
> >   (hibernation_mode == HIBERNATION_PLATFORM && hibernation_ops) 
> > to just
> >   (hibernation_mode == HIBERNATION_PLATFORM)
> > in various if statements and other places.
> 
> No, that's not a good idea, because of the "reduce code duplication patch"
> that I'd like to go on top of this.  I'd rather use 'if (hibernation_ops)' here. :-)

But if you want the user to be able to change away from 'platform' mode
you still have to have
  if (hibernation_ops && hibernation_mode == HIBERNATION_PLATFORM)
in most places, no?

johannes

Attachment: signature.asc
Description: This is a digitally signed message part