On 5/6/07, Wim Van Sebroeck <[email protected]> wrote:
Hi Dan,
> Here is a new watchdog driver for your review. It supports two flavors
> of the iop watchdog timer. The iop13xx watchdog can be stopped while
> the iop3xx version cannot.
I started reviewing this patch yesterday. First thing I noticed was that
you seem to be moving some code from include/asm-arm/arch-iop13xx/system.h
to include/asm-arm/arch-iop13xx/iop13xx.h .
This should not be part of this patch since it is touching architecture
dependant code for which I do not have enough knowledge about this specific
architecture to tell if this is indeed the correct way to do this.
The maintainers of this architecture should imho comment on this.
Could you split this patch into 2 patches: one that deals with the moving of
the architecture dependant code (and explaining why) and one with the new
watchdog drivers? I will continue my review today.
I am one of the maintainers of this architecture, (Lennert Buytenhek
is the other). I will go ahead and split this up so you can sign-off
on the watchdog specific bits. The intent is to move all hardware
definitions under #include <asm/hardware.h>. You are right this
should have been a separate patch.
Thanks,
Wim.
Thanks for your help,
Dan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
