Re: [PATCH] synclink_gt add compat_ioctl

[Paul Fulghum <paulkf@microgate.com>]

Arnd Bergmann wrote:
> On Friday 04 May 2007, Paul Fulghum wrote:
> > > - It is fishy that apart from one outlier in kexec.h, synclink.h is the
> > >   only header file which uses compat_ulong_t.  Are we doing this right?
> > Arnd, do you have any comment on this?
>
> I think most others just define the compat data structures in the
> same file that implements the headers, inside the same #ifdef that
> hides the functions using them.
> This makes sense, because the data structures here don't define
> an interface, but rather describe what the interface looks like
> in the 32 bit case.

OK, moving the compatible structure declarations from the header
to the individual source files will fix all the header mess and
the odd compilation errors on i386 when using the compat.h header
inside of another header.

That declaration will need to be duplicated in each driver that
uses it (4 drivers in my case). In that sense (a structure declaration
used by multiple code modules) it does seem like an interface definition.

If that is what is needed, I will do it.

--
Paul

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/