Re: [PATCH] synclink_gt add compat_ioctl

[Paul Fulghum <paulkf@microgate.com>]

Andrew Morton wrote:
> In file included from drivers/char/synclink_gt.c:85:
> include/linux/synclink.h:175: error: expected specifier-qualifier-list before 'compat_ulong_t'
>
> - We might as well do the same ifdef-avoidery trick around compat_ioctl()
>   too.  That required that it be renamed.
>
> - It is fishy that apart from one outlier in kexec.h, synclink.h is the
>   only header file which uses compat_ulong_t.  Are we doing this right?

Arnd, do you have any comment on this?

It seems like the compatible types should be available
in something that is already commonly used like linux/types.h

I'm fine with it either way. I'm not in
a position to be making those kinds of decisions
for widely used infrastructure, so I'll leave
that for someone further up the food chain.

--
Paul Fulghum
Microgate Systems, Ltd.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/