Re: [git pull] New firewire stack

[Kristian Høgsberg <krh@redhat.com>]

Adrian Bunk wrote:
> On Wed, May 02, 2007 at 02:48:11PM +0200, Stefan Richter wrote:
> > Olaf Hering wrote:
> > > On Tue, May 01, Kristian Høgsberg wrote:
> > >
> > > >   drivers/firewire/Kconfig          |   60 ++
> > > NACK.
> > > Upgrade the current drivers/ieee1394/ with the new code,
> > Last time I believe I was the only one who asked whether to put it into
> > drivers/ieee1394 instead of another directory.  Of course I acknowledge
> > that everytime a new review round is started, people do reconsider.
> > Especially since we had a gap of a few months since the last LKML review.
> >
> > > and keep all existing module names.
> > I'm impartial to that.  Using same names might ease the transition from
> > the userspace side, as far as there is userland which relies on module
> > names.
> >
> > A certain drawback of same names would be that geeks cannot install both
> > stacks at once during the transition period.  Therefore, checking
> > whether eventual problems are in fact regressions involves a module
> > unload/ configure/ build/ install/ reload cycle, instead of just module
> > unload/ reload.  This especially means we can only get help from testers
> > who are able to build kernels.
> >
> > Other opinions?
>
> An advantage of changing the names is that they are now prefixed.
> But looking at them, there will again be the point whether everyone will 
> think that "fw" is firmware, and perhaps switching to the (although 
> longer) prefix "firewire" might make sense?

I like "firewire" better, I'm already using that for the userspace header 
file.  Renaming the modules to firewire-core, firewire-ohci and firewire-sbp2 
sounds good to me.

Kristian

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/