Re: [PATCH] sworks-agp: Switch to PCI ref counting APIs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 26 Apr 2007 00:20:19 -0400
Dave Jones <[email protected]> wrote:

> On Wed, Apr 25, 2007 at 07:21:58PM -0700, Andrew Morton wrote:
>  > On Mon, 23 Apr 2007 14:51:29 +0100 Alan Cox <[email protected]> wrote:
>  > 
>  > >  {
>  > >  	struct agp_bridge_data *bridge = pci_get_drvdata(pdev);
>  > >  
>  > > +	pci_dev_put(bridge->dev);
>  > >  	agp_remove_bridge(bridge);
>  > >  	agp_put_bridge(bridge);
>  > > +	pci_dev_put(serverworks_private.svrwrks_dev)
>  > > +	serverworks_private.svrwrks_dev = NULL;
>  > 
>  > err, guys?
> 
> ? One put for the agp bridge, one for the host bridge.
> What am I missing?

Nothing - I assume Andrew was referring the bizarre way one of the
devices is global and one is per structure ?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux