Re: [PATCH] sworks-agp: Switch to PCI ref counting APIs

[Dave Jones <davej@redhat.com>]

On Wed, Apr 25, 2007 at 09:23:39PM -0700, Andrew Morton wrote:
 > On Thu, 26 Apr 2007 00:20:19 -0400 Dave Jones <davej@redhat.com> wrote:
 > 
 > > On Wed, Apr 25, 2007 at 07:21:58PM -0700, Andrew Morton wrote:
 > >  > On Mon, 23 Apr 2007 14:51:29 +0100 Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
 > >  > 
 > >  > >  {
 > >  > >  	struct agp_bridge_data *bridge = pci_get_drvdata(pdev);
 > >  > >  
 > >  > > +	pci_dev_put(bridge->dev);
 > >  > >  	agp_remove_bridge(bridge);
 > >  > >  	agp_put_bridge(bridge);
 > >  > > +	pci_dev_put(serverworks_private.svrwrks_dev)
 > >  > > +	serverworks_private.svrwrks_dev = NULL;
 > >  > 
 > >  > err, guys?
 > > 
 > > ? One put for the agp bridge, one for the host bridge.
 > > What am I missing?
 > > 
 > 
 > a semicolon.

Yow. I thought I build tested that.
I'll regenerate the git tree tomorrow. Same goes for the cpufreq
tree with the acpi fixup.

Thanks.

	Dave

-- 
http://www.codemonkey.org.uk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/