Re: [RFC][PATCH] fix abs() macro to work with types wider than int

On Wed, 25 Apr 2007, Andreas Schwab wrote:

> "linux-os (Dick Johnson)" <[email protected]> writes:
>
>> I think this works, regardless of the length of the integers:
>>
>> #define abs(x) (((x)<0)?-(x):(x))
>
> But it evaluates its argument more than once.
>
> Andreas.
>

Sure. Macros do that. If that's not okay, then you need either
a temporary variable or a function. The original query was for
a macro. Any macro that tests something then returns a value
based upon the test is going to have that problem. Any attempt
to just AND off a sign bit is going to have width problems. You
can't have your cake and eat it too. Even whacking off the sign-
bit may fail because there may be two variable accesses which could
mean two function calls, destroying the logic.


Cheers,
Dick Johnson
Penguin : Linux version 2.6.16.24 on an i686 machine (5592.62 BogoMips).
New book: http://www.AbominableFirebug.com/
_


****************************************************************
The information transmitted in this message is confidential and may be privileged.  Any review, retransmission, dissemination, or other use of this information by persons or entities other than the intended recipient is prohibited.  If you are not the intended recipient, please notify Analogic Corporation immediately - by replying to this message or by sending an email to [email protected] - and destroy all copies of this information, including any attachments, without reading or disclosing them.

Thank you.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [RFC][PATCH] fix abs() macro to work with types wider than int
    • From: Andreas Schwab <[email protected]>

• References:
  • [RFC][PATCH] fix abs() macro to work with types wider than int
    • From: Jiri Bohac <[email protected]>
  • Re: [RFC][PATCH] fix abs() macro to work with types wider than int
    • From: Randy Dunlap <[email protected]>
  • Re: [RFC][PATCH] fix abs() macro to work with types wider than int
    • From: Richard Knutsson <[email protected]>
  • Re: [RFC][PATCH] fix abs() macro to work with types wider than int
    • From: Randy Dunlap <[email protected]>
  • Re: [RFC][PATCH] fix abs() macro to work with types wider than int
    • From: "John Anthony Kazos Jr." <[email protected]>
  • Re: [RFC][PATCH] fix abs() macro to work with types wider than int
    • From: "linux-os \(Dick Johnson\)" <[email protected]>
  • Re: [RFC][PATCH] fix abs() macro to work with types wider than int
    • From: Andreas Schwab <[email protected]>

• Prev by Date: Re: suspend2 merge (was Re: [Suspend2-devel] Re: CFS and suspend2: hang in atomic copy)
• Next by Date: Re: suspend2 merge (was Re: [Suspend2-devel] Re: CFS and suspend2: hang in atomic copy)
• Previous by thread: Re: [RFC][PATCH] fix abs() macro to work with types wider than int
• Next by thread: Re: [RFC][PATCH] fix abs() macro to work with types wider than int
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]