* Daniel Walker <[email protected]> wrote: > On Tue, 2007-04-24 at 13:24 -0700, Jeremy Fitzhardinge wrote: > > > And sched_clock's use of local_irq_save/restore appears to be absolutely > > correct, so I think it must be triggering a bug in either the self-tests > > or lockdep itself. > > Why does sched_clock need to disable interrupts? i concur. To me it appears not "absolutely correct" that someone apparently added local_irq_save/restore to sched_clock(), but "absolute madness". sched_clock() is _very_ performance-sensitive for the scheduler, do not mess with it. Ingo - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [patch 1/4] Ignore stolen time in the softlockup watchdog
- From: Andrew Morton <[email protected]>
- Re: [patch 1/4] Ignore stolen time in the softlockup watchdog
- From: Daniel Walker <[email protected]>
- Re: [patch 1/4] Ignore stolen time in the softlockup watchdog
- References:
- Re: [patch 1/4] Ignore stolen time in the softlockup watchdog
- From: Andrew Morton <[email protected]>
- Re: [patch 1/4] Ignore stolen time in the softlockup watchdog
- From: Jeremy Fitzhardinge <[email protected]>
- Re: [patch 1/4] Ignore stolen time in the softlockup watchdog
- From: Andrew Morton <[email protected]>
- Re: [patch 1/4] Ignore stolen time in the softlockup watchdog
- From: Jeremy Fitzhardinge <[email protected]>
- Re: [patch 1/4] Ignore stolen time in the softlockup watchdog
- From: Andrew Morton <[email protected]>
- Re: [patch 1/4] Ignore stolen time in the softlockup watchdog
- From: Jeremy Fitzhardinge <[email protected]>
- Re: [patch 1/4] Ignore stolen time in the softlockup watchdog
- From: Jeremy Fitzhardinge <[email protected]>
- Re: [patch 1/4] Ignore stolen time in the softlockup watchdog
- From: Daniel Walker <[email protected]>
- Re: [patch 1/4] Ignore stolen time in the softlockup watchdog
- Prev by Date: Re: Pagecache: find_or_create_page does not call a proper page allocator function
- Next by Date: Re: [Intel IOMMU][patch 4/8] Supporting Zero Length Reads in Intel IOMMU.
- Previous by thread: Re: [patch 1/4] Ignore stolen time in the softlockup watchdog
- Next by thread: Re: [patch 1/4] Ignore stolen time in the softlockup watchdog
- Index(es):