On Sun, 22 Apr 2007, Nicolas Pitre wrote:
> On Sun, 22 Apr 2007, Junio C Hamano wrote:
>
> > Nicolas Pitre <[email protected]> writes:
> >
> > > On Sun, 22 Apr 2007, Junio C Hamano wrote:
> > >
> > >> With recent glibc, mkstemp() creates 0400 file. Updated
> > >> pack-objects uses it in pack/idx writing without fixing this,
> > >> hence this problem.
> > >
> > > Oops. I guess I'm guilty for this. I didn't bother looking at the
> > > permission on the pack for git-pack-objects since git-repack seemed to
> > > take care of that. But it only _remove_ write permissions.
> >
> > Ok, then probably we can change the 0444 in my "quickfix" patch
> > to 0644. That should also let the 5300 test pass.
>
> Well, actually there is no point making pack files writable. If they're
> modified, they get corrupted.
OK there are those test cases.
Well... Either we chmod to 0644, or we fix the tests to 'chmod +w' like
it is already done in t5302.
In any case I wouldn't die() but only error() on a failure to chmod().
It is sure inconvenient if the pack isn't world readable, but it is not
a "fatal" problem for the repack.
Nicolas
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
