On Sat, Apr 21, 2007 at 02:06:22PM -0700, Andrew Morton wrote: > On Sat, 21 Apr 2007 22:01:47 +0100 Alan Cox <[email protected]> wrote: > > > > > +#define lower_32_bits(n) (sizeof(n) == 8 ? (u32)(n) : (n)) > > > > > > n&0xffffffff would be simpler. > > > > > > Do we actually have any call for this? > > > > The only case for all of this we care about is sector_t, which is one > > type, with specific properties (eg always being positive). The rest is > > over-engineering. Call it sector_upper32() do it the simple way and stop > > trying to solve a problem we don't have > > James said we have the same problem with dma_addr_t. Yes. It's in fact the far more common case and we have a bread of macros dealing with the issue in various drivers. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- References:
- Re: [PATCH] cciss: Fix warnings during compilation under 32bitenvironment
- From: Andrew Morton <[email protected]>
- Re: [PATCH] cciss: Fix warnings during compilation under 32bitenvironment
- From: James Bottomley <[email protected]>
- Re: [PATCH] cciss: Fix warnings during compilation under 32bitenvironment
- From: Andrew Morton <[email protected]>
- Re: [PATCH] cciss: Fix warnings during compilation under 32bitenvironment
- From: James Bottomley <[email protected]>
- Re: [PATCH] cciss: Fix warnings during compilation under 32bitenvironment
- From: Andrew Morton <[email protected]>
- Re: [PATCH] cciss: Fix warnings during compilation under 32bitenvironment
- From: "John Anthony Kazos Jr." <[email protected]>
- [PATCH] utilities: add helper functions for safe 64-bit integer operations as 32-bit halves
- From: "John Anthony Kazos Jr." <[email protected]>
- Re: [PATCH] utilities: add helper functions for safe 64-bit integer operations as 32-bit halves
- From: Andrew Morton <[email protected]>
- Re: [PATCH] utilities: add helper functions for safe 64-bit integer operations as 32-bit halves
- From: Alan Cox <[email protected]>
- Re: [PATCH] utilities: add helper functions for safe 64-bit integer operations as 32-bit halves
- From: Andrew Morton <[email protected]>
- Re: [PATCH] cciss: Fix warnings during compilation under 32bitenvironment
- Prev by Date: Re: [ANNOUNCE] Staircase Deadline cpu scheduler version 0.45
- Next by Date: [PATCH -stable] KVM: MMU: Fix guest writes to nonpae pde
- Previous by thread: Re: [PATCH] utilities: add helper functions for safe 64-bit integer operations as 32-bit halves
- Next by thread: Re: [PATCH] utilities: add helper functions for safe 64-bit integer operations as 32-bit halves
- Index(es):
 |