Re: [PATCH] utilities: add helper functions for safe 64-bit integer operations as 32-bit halves

> > +#define lower_32_bits(n) (sizeof(n) == 8 ? (u32)(n) : (n))
> 
> n&0xffffffff would be simpler.
> 
> Do we actually have any call for this?

The only case for all of this we care about is sector_t, which is one
type, with specific properties (eg always being positive). The rest is
over-engineering. Call it sector_upper32() do it the simple way and stop
trying to solve a problem we don't have
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] utilities: add helper functions for safe 64-bit integer operations as 32-bit halves
    • From: Andrew Morton <[email protected]>

• References:
  • RE: [PATCH] cciss: Fix warnings during compilation under 32bit environment
    • From: "Miller, Mike (OS Dev)" <[email protected]>
  • RE: [PATCH] cciss: Fix warnings during compilation under 32bit environment
    • From: James Bottomley <[email protected]>
  • RE: [PATCH] cciss: Fix warnings during compilation under 32bit environment
    • From: "Miller, Mike (OS Dev)" <[email protected]>
  • RE: [PATCH] cciss: Fix warnings during compilation under 32bit environment
    • From: James Bottomley <[email protected]>
  • RE: [PATCH] cciss: Fix warnings during compilation under 32bitenvironment
    • From: "Cameron, Steve" <[email protected]>
  • Re: [PATCH] cciss: Fix warnings during compilation under 32bitenvironment
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH] cciss: Fix warnings during compilation under 32bitenvironment
    • From: James Bottomley <[email protected]>
  • Re: [PATCH] cciss: Fix warnings during compilation under 32bitenvironment
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH] cciss: Fix warnings during compilation under 32bitenvironment
    • From: James Bottomley <[email protected]>
  • Re: [PATCH] cciss: Fix warnings during compilation under 32bitenvironment
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH] cciss: Fix warnings during compilation under 32bitenvironment
    • From: James Bottomley <[email protected]>
  • Re: [PATCH] cciss: Fix warnings during compilation under 32bitenvironment
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH] cciss: Fix warnings during compilation under 32bitenvironment
    • From: "John Anthony Kazos Jr." <[email protected]>
  • [PATCH] utilities: add helper functions for safe 64-bit integer operations as 32-bit halves
    • From: "John Anthony Kazos Jr." <[email protected]>
  • Re: [PATCH] utilities: add helper functions for safe 64-bit integer operations as 32-bit halves
    • From: Andrew Morton <[email protected]>

• Prev by Date: Re: [PATCH] Remove "obsolete" label from ISDN4Linux (v3)
• Next by Date: Re: [patch 7/8] allow unprivileged mounts
• Previous by thread: Re: [PATCH] utilities: add helper functions for safe 64-bit integer operations as 32-bit halves
• Next by thread: Re: [PATCH] utilities: add helper functions for safe 64-bit integer operations as 32-bit halves
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]