On Thu, 2007-04-19 at 16:12 +0000, Miller, Mike (OS Dev) wrote:
> > > Nak. You still haven't told where you saw these warnings. What
> > > compiler are you using? I do not see these in my 32-bit environment.
> >
> > I think it's seen with CONFIG_LBD=n on 32 bits
> >
> > In that configuration, sector_t is a u32 (it's u64 even on 32
> > bits with CONFIG_LBD=y). The proposed code change is a
> > simple cut and paste from the sd driver.
>
> Isn't there a better way than testing each one?
It's not such a bad option. The sizeof() test is compile time
determinable, so the compiler simply zeros the fields in the
CONFIG_LBD=n case and does the shift for CONFIG_LBD=y. It certainly
never compiles to four inline condition checks.
James
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
