Re: [patch] CFS (Completely Fair Scheduler), v2

[Ingo Molnar <mingo@elte.hu>]

* Nick Piggin <npiggin@suse.de> wrote:

> >                   list_add_tail(&p->run_list, &current->run_list);
[...]
> > shouldnt the list_add_tail() be list_add(), so that task pickup sees 
> > the child first? [...]
[...]
> I think that it works because the list we're adding to is not the 
> normal runqueue list head, but the parent's list_head on that 
> runqueue. Which adds the child directly ahead of the parent... I 
> think?

yeah, you are right, i was confused: list_add() adds _after_ the head, 
list_add_tail() adds _before_ the head - and in the middle of the list 
if we do a list_add_tail() it adds before that entry. So everything's 
fine and working as expected :)

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/